Fix and improve warning about attribute setting in config profiles [ci-skip] #4441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[ci-skip] Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
mribeirodantas
force-pushed
the
fix-danger-config-docs
branch
from
32007fd to
52e381c
Compare
Member
Author
|
LGTM? 😃 |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
5a93547 to
27345a6
Compare
Member
|
Thanks Marcel for your contribution. Sorry that it was neglected for so long. I was always unsure about which cases were actually affected by this bug, so I tested a bunch of combinations and the one added by this PR is the only failing case: profiles {
foo {
process.memory = '2 GB'
process {
cpus = 2
}
}
}$ nextflow config -profile foo
process {
cpus = 2
}Since we are planning to merge #4744 soon, I will incorporate this example into that PR so that I can recommend the strict config syntax as a solution. Otherwise it just looks like we are documenting a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.